Generalize correction application in cities #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzaponte
force-pushed
the
different-corrections
branch
2 times, most recently
from
e358775 to
fd1724c
Compare
gonzaponte
force-pushed
the
different-corrections
branch
from
fd1724c to
46f7881
Compare
jwaiton
reviewed
Nov 2, 2024
jwaiton
reviewed
Nov 5, 2024
Comment on lines
+481
to
+484
| def test_hits_corrector_valid_normalization_options( correction_map_filename | ||
| , norm_strat | ||
| , norm_value | ||
| , apply_temp ): |
There was a problem hiding this comment.
A docstring to explain this test may be useful, although I think its self explanatory. I think test_hits_corrector_invalid_normalization_options_raises doesn't require one as the comments describing the fixtures + the name of the test explain (at least to me) what the test is looking to do.
jwaiton
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the cities to apply corrections in a more general way. Currently, the correction strategy is hard-wired to
NormStrategy.krwhich limits our capabilities. This PR extends the method to allow different correction strategies.