Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add provider/adpaters logos in dark mode #11232

Closed

Conversation

dhairyathedev
Copy link
Contributor

☕️ Reasoning

The icons were breaking in dark mode because their dark colors didn’t provide enough contrast.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

📌 Resources

Copy link

vercel bot commented Jun 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 10:03am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Jun 22, 2024 10:03am

Copy link

vercel bot commented Jun 22, 2024

@dhairyathedev is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@ndom91
Copy link
Member

ndom91 commented Jun 24, 2024

Can you provide a screenshot? Where do you mean it was breaking exactly?

Were trying to avoid maintaining two copies of each logo

@dhairyathedev
Copy link
Contributor Author

One example is https://authjs.dev/getting-started/authentication/oauth where the GitHub and Okta logo is not visible in dark mode. There are lots of logos in providers list where the image is not visible in dark mode.

image

Were trying to avoid maintaining two copies of each logo

Actually I tried changing the fill color using tailwind css, but it is not possible to change the fill color of path in svg when rendered using img tag. The solution to this issue, is to use SVG directly in the code or creating seperate variant for dark mode.

If you know a better way then please let me know.

@balazsorban44
Copy link
Member

as said, we are trying to avoid more icons.

Let's revisit this in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants