Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary code #11979

Merged

Conversation

halvaradop
Copy link
Contributor

☕️ Reasoning

This pull request removes unnecessary code by:

  • Deleting the generate-providers.js file from the next-auth package.
  • Removing the --out flag in the providers command for both the @auth/qwik and @auth/solid-start packages.

These changes are made because there is an existing file in the utils package that allows for the generation of providers. This utility has a default value that specifies the content output directory as src.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

@halvaradop halvaradop requested a review from ThangHuuVu as a code owner October 5, 2024 19:14
Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 7:19pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Oct 5, 2024 7:19pm

Copy link

vercel bot commented Oct 5, 2024

@halvaradop is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.18%. Comparing base (4a90ad9) to head (cf85ed9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11979   +/-   ##
=======================================
  Coverage   39.18%   39.18%           
=======================================
  Files         190      190           
  Lines       29845    29845           
  Branches     1290     1290           
=======================================
  Hits        11696    11696           
  Misses      18149    18149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@balazsorban44 balazsorban44 merged commit 340b41d into nextauthjs:main Oct 5, 2024
13 of 15 checks passed
@halvaradop halvaradop deleted the chore/remove-unnecesary-code branch November 30, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants