Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilePicker: Signal folder creation to files app #1095

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Oct 31, 2023

@susnux susnux requested a review from skjnldsv October 31, 2023 23:42
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #1095 (536be9f) into main (756a18b) will increase coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1095      +/-   ##
==========================================
+ Coverage   30.44%   30.52%   +0.08%     
==========================================
  Files          16       16              
  Lines        1222     1222              
  Branches       61       60       -1     
==========================================
+ Hits          372      373       +1     
  Misses        791      791              
+ Partials       59       58       -1     
Files Coverage Δ
lib/composables/dav.ts 91.89% <100.00%> (+0.90%) ⬆️

Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an easy way, but fetching the full list of file for a single created file isn't the best optimised way :)

@susnux
Copy link
Contributor Author

susnux commented Nov 1, 2023

Seems like an easy way, but fetching the full list of file for a single created file isn't the best optimised way :)

True, will do in a follow up

@susnux susnux merged commit c1596fe into main Nov 1, 2023
@susnux susnux deleted the fix/emit-signal branch November 1, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit files:node:created when folder is created
2 participants