Skip to content

Commit

Permalink
fix: Add vue-router as peer-dependency as we make explicit use of it
Browse files Browse the repository at this point in the history
Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
susnux committed Sep 25, 2023
1 parent 7a251c8 commit 265abd0
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 9 deletions.
31 changes: 26 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -100,14 +100,14 @@
"vue-material-design-icons": "^5.1.2"
},
"peerDependencies": {
"vue": "^3.3.4"
"vue": "^3.3.4",
"vue-router": "^4.2.0"
},
"engines": {
"node": "^20.0.0",
"npm": "^9.0.0"
},
"devDependencies": {
"@babel/plugin-syntax-import-assertions": "^7.22.5",
"@babel/preset-typescript": "^7.22.15",
"@cypress/vue": "^6.0.0",
"@fontsource/roboto": "^5.0.0",
Expand Down
6 changes: 4 additions & 2 deletions src/components/NcButton/NcButton.vue
Original file line number Diff line number Diff line change
Expand Up @@ -322,11 +322,13 @@ export default {
</docs>

<script lang="ts">
import isSlotPopulated from '../../utils/isSlotPopulated.js'
import type { PropType } from 'vue'

import { type PropType, defineComponent, h } from 'vue'
import { defineComponent, h } from 'vue'
import { RouterLink } from 'vue-router'

import isSlotPopulated from '../../utils/isSlotPopulated.js'

const BUTTON_ALIGNMENT = ['start', 'start-reverse', 'center', 'center-reverse', 'end', 'end-reverse'] as const
const BUTTON_TYPES = ['primary', 'secondary', 'tertiary', 'tertiary-no-background', 'tertiary-on-primary', 'error', 'warning', 'success'] as const
const NATIVE_TYPES = ['submit', 'reset', 'button'] as const
Expand Down

0 comments on commit 265abd0

Please sign in to comment.