-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New list item component, action menu mobile use and accessbility #2340
Comments
iirc, this is a two-step tab, when you tab the menu appear, no @marcoambrosini ? |
Yes it is @skjnldsv though on mobile there's no tab key :) |
Sorry, didn't thought of mobile. |
@jancborchardt @nimisha-vijay could one of you look into this? |
I don't know if it fits here, but I just noticed that tabbing through the messages only works forwards. Tabbing backwards (with shift+tab) does not work. |
As an input, this is how Hey, Protonmail and Gmail solve this problem. Screen.Recording.2021-08-18.at.15.50.13.movRPReplay_Final1629294203.MP4RPReplay_Final1629294153.MP4Currently, tapping the avatar doesn't do anything other than showing a tooltip with the name of the contact. We could remove that (it's shown already as the title of the listitem anyway) and trigger selection mode on tap. That way actions would be always available in the topbar. |
I’m not fully sure about the discoverability of that, especially because when you want to change 1 thing you don’t think about multiselect. Also, you need to press on the left of an element, the opposite of where you normally go. @nimisha-vijay @skjnldsv @ChristophWurst what do you think? Whatever we go with: For mobile it would be nice that the currently active element also shows the menu, so when you go back to open the navigation it directly shows. |
For Mail that means you have to open each of the messages to reveal the menu. If you just open your inbox then there is no menu handle. |
This wouldn't help here because the list would be collapsed on tap and the active element hidden to make room for the content. What about having the selection checkbox always visible on mobile, similar to gmail? |
So @marcoambrosini @nimisha-vijay and I talked about this and came to the conclusion:
@ChristophWurst @skjnldsv what do you think? |
I transfered to the vue repo since it doesn't affect mail only. So I guess that we need some sort of |
How would that solve the fact that it's basically not accessible on mobile at all. |
In my view we can default with actions on on mobile too in the case of talk, as long as we don't reintroduce them in the main (desktop) web UI |
IMO the actions in the menu are not always frequently used. Hiding them for some cases is okay, especially when it takes valuable real estate on a tiny screen. This needs to be thought about for each app though, we can't just hide the menus in all the apps. |
Thank you. @marcoambrosini can you do that please? |
Sure, I'm just not sure about how it should look, hence this. |
Yup, sounds good. And then making it look like Marco proposed at #2340 (comment) would work.
The issue here is that the differentiation is not mobile/desktop, but it’s touch/non-touch, and we can’t reliably differentiate that. People might have a tablet which is as big as some screens (iPad Pro) or they have a laptop with a touchscreen. |
Mail uses the new app content list item component from nc/vue. This looks and works great on desktop, but on mobile there is a little accessibility issue IMO. The issues is that by default we always show the timestamp of the message, on hover (desktop) the actions menu handle shows. There is no hover on mobile, so that menu is a "hidden" feature. You can still click and get a menu, but a user wouldn't know about this.
@nextcloud/designers possibly something to discuss
The text was updated successfully, but these errors were encountered: