Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV]: Rework native tooltips on NcAvatar #3677

Closed
2 tasks
Tracked by #2503
JuliaKirschenheuter opened this issue Jan 25, 2023 · 0 comments · Fixed by #3678
Closed
2 tasks
Tracked by #2503

[BITV]: Rework native tooltips on NcAvatar #3677

JuliaKirschenheuter opened this issue Jan 25, 2023 · 0 comments · Fixed by #3678
Assignees
@JuliaKirschenheuter
Labels
2. developing Work in progress accessibility Making sure we design for the widest range of people possible, including those who have disabilities

Comments

@JuliaKirschenheuter
Copy link
Contributor

Problem

To show a tooltip on a several components we currently use v-tooltip. An example can be found in https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/NcAvatar/NcAvatar.vue#L112

v-tooltip is not accessible and we want to migrate to native tooltips (title attribute) instead. An overview can be found in #2503.

Solution / ToDo:

  • Add a title prop to NcAvatar component that will render as title attribute on the HTML element. Remove custom tooltips.
  • Show valid value for aria-label every time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
2. developing Work in progress accessibility Making sure we design for the widest range of people possible, including those who have disabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace custom toolip with native one on Avatar component nextcloud-libraries/nextcloud-vue
1 participant
@JuliaKirschenheuter