Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom toolip with native one on Avatar component #3678

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Replace custom toolip with native one on Avatar component #3678

merged 1 commit into from
Feb 2, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Jan 25, 2023 •
edited
Loading

Fixes #3677

  • Remove custom tooltips.
  • Remove unneeded props aria-label and title.
Before After
Screenshot from 2023-01-25 15-26-14 Screenshot from 2023-01-25 15-22-51
Screenshot from 2023-01-25 15-25-58 Screenshot from 2023-01-25 15-23-03

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Jan 25, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jan 25, 2023
skjnldsv
skjnldsv previously requested changes Jan 25, 2023
View reviewed changes
src/components/NcAvatar/NcAvatar.vue Show resolved Hide resolved
@JuliaKirschenheuter
Replace custom toolip with native one on Avatar component. Show valid…
5245a8c 
… value for aria-label every time.

Signed-off-by: julia.kirschenheuter <[email protected]>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/3677-Rework_native_tooltips_on_NcAvatar branch from 8a63c27 to 5245a8c Compare January 30, 2023 10:32
@JuliaKirschenheuter JuliaKirschenheuter changed the title Replace custom toolip with native one on Avatar component. Show valid value for aria-label every time. Replace custom toolip with native one on Avatar component Feb 2, 2023
@skjnldsv skjnldsv dismissed their stale review February 2, 2023 09:37

Addresses

@JuliaKirschenheuter JuliaKirschenheuter merged commit 96f21f2 into master Feb 2, 2023
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/3677-Rework_native_tooltips_on_NcAvatar branch February 2, 2023 09:40
@Pytal Pytal mentioned this pull request Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@Pytal Pytal Pytal approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@st3iny st3iny Awaiting requested review from st3iny

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BITV]: Rework native tooltips on NcAvatar
5 participants
@JuliaKirschenheuter @nickvergessen @ChristophWurst @skjnldsv @Pytal