-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make avatar menu focusable with keyboard #1854
Conversation
I managed to make this work by automatically setting the focus on the first element inside the menu. So you can hit enter to open the trigger, then hit enter again on a menu link. And when the popover is open, if you hit the Escape key, the popover closes and you're back on the trigger. That's near. Minimal, but neat. |
Note: I've developed and tested this with the Talk app and with the participant list on the right of a conversation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and works
/backport to stable3 |
Signed-off-by: Vincent Petry <[email protected]>
Signed-off-by: Vincent Petry <[email protected]>
f2ef074
to
5009616
Compare
Signed-off-by: Vincent Petry <[email protected]>
The backport to stable3 failed. Please do this backport manually. |
Fixes #613
This makes the avatar component focussable with the keyboard and also hitting the enter key will open the menu.
However the menu is not navigable and I'm not sure if we want to reimplement arrow navigation there.
Also, I heard that there will be a revamp of that popover, so the interaction in that popover would be different