Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slot for third line in listitem component #1888

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

marcoambrosini
Copy link
Contributor

Screenshot from 2021-04-27 16-00-41

Signed-off-by: Marco Ambrosini [email protected]

@marcoambrosini marcoambrosini self-assigned this Apr 27, 2021
@marcoambrosini marcoambrosini added 3. to review Waiting for reviews component Component discussion and/or suggestion labels Apr 27, 2021
@marcoambrosini marcoambrosini added this to the 4.0.0 milestone Apr 27, 2021
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best reviewed as https://github.com/nextcloud/nextcloud-vue/pull/1888/files?w=1

Looks good, but didn't test with the tags in Mail. @GretaD mind doing a smoke test with your changes? :)

@marcoambrosini
Copy link
Contributor Author

Thanks for all the love :)

@marcoambrosini marcoambrosini merged commit 07b4064 into master Apr 28, 2021
@marcoambrosini marcoambrosini deleted the feature/add-slot-for-third-line-in-listitem branch April 28, 2021 08:37
@marcoambrosini marcoambrosini added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 28, 2021
@skjnldsv skjnldsv mentioned this pull request Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish component Component discussion and/or suggestion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants