Merge Dashboard components into repository #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
fix/noid/dashboard
branch
3 times, most recently
from
facc3c7 to
bdad030
Compare
Signed-off-by: Raimund Schlüßler <[email protected]>
Signed-off-by: Raimund Schlüßler <[email protected]>
Signed-off-by: Raimund Schlüßler <[email protected]>
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
fix/noid/dashboard
branch
from
bdad030 to
add6943
Compare
raimund-schluessler
requested review from
julien-nc,
nickvergessen,
juliusknorr,
marcoambrosini,
korelstar and
skjnldsv
korelstar
approved these changes
May 3, 2022
skjnldsv
reviewed
May 4, 2022
skjnldsv
reviewed
May 4, 2022
skjnldsv
reviewed
May 4, 2022
skjnldsv
reviewed
May 4, 2022
skjnldsv
reviewed
May 4, 2022
skjnldsv
reviewed
May 4, 2022
Signed-off-by: Raimund Schlüßler <[email protected]>
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
fix/noid/dashboard
branch
from
add6943 to
cadc116
Compare
|
@skjnldsv All done. 🙂 |
raimund-schluessler
added
3. to review
juliusknorr
approved these changes
May 4, 2022
This was referenced May 13, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the two Dashboard components
DashboardWidgetandDashboardWidgetIteminto the repository. Please see nextcloud-libraries/nextcloud-vue-dashboard#407 for the reasoning of doing so.The first commit of this PR just copies the components from
nextcloud-vue-dashboard(besides a small adjustment to the required component imports). The later commits adjust the components to the behavior ofnextcloud/vue. I also added documentation for them, for which I had do adjust the documentation previously present in thenextcloud-vue-dashboardrepo, because it didn't match the components behavior (there e.g are nofooterandheaderslots, which are mentioned there).Please have a look at the documentation: https://deploy-preview-2668--nextcloud-vue-components.netlify.app/#/Components/Dashboard
Once this PR is merged and released, we should archive the
nextcloud-vue-dashboardrepository and add a link thenextcloud-vue.