Improve multiselect #3100
Merged
Improve multiselect #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add focus effect for better accessibility - Increase font size to be 15px like the other component - Update style to be more like the NcInputField There is still some remaining issues that are not fixed by this PR, notably the width of the multiselect component change when clicking on it. This is a preexisting issue Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
added
enhancement
CarlSchwan
requested review from
jancborchardt,
raimund-schluessler and
marcoambrosini
jancborchardt
approved these changes
Aug 25, 2022
Yeah here is a before screenshot
|
CarlSchwan
commented
Aug 26, 2022
Signed-off-by: Carl Schwan <[email protected]>
max-nextcloud
approved these changes
Aug 30, 2022
ChristophWurst
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still some remaining issues that are not fixed by this PR,
notably the width of the multiselect component change when clicking
on it. This is a preexisting issue :(