Fix AppNavigationItem actions visibility #3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
added
bug
|
/backport to stable6 |
raimund-schluessler
force-pushed
the
fix/3094/appnavigation-active
branch
2 times, most recently
from
f22d07e to
e4c86a0
Compare
raimund-schluessler
requested review from
skjnldsv,
PVince81,
GretaD,
juliusknorr,
marcoambrosini and
ChristophWurst
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
fix/3094/appnavigation-active
branch
from
e4c86a0 to
b5b7cb9
Compare
ChristophWurst
approved these changes
Sep 5, 2022
Merged
CarlSchwan
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all issues I described in #3094 (comment):
AppNavigationItemis activeAppNavigationItemhas the undo stateAppNavigationItemis editableI had to switch from JS to CSS and hover/focus/active classes, because the active state is applied by
router-linkand not easily accessible in JS (one could switch to a scoped slot, but that creates different trouble). However, I think handling the hover/focus in CSS is anyway more performant and creates less issues (I saw some weird glitches with the JS implementation, probably the mouseover events were not correctly called).The alignment of the counter might need some adjustments still, but I would propose to fix this in a follow-up PR to first get it working and then do the fine-tuning.