Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make app navigation settings pixel perfect-ish #3256

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Make app navigation settings pixel perfect-ish #3256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/assets/variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,6 @@ $breakpoint-mobile: 1024px;

// top-bar spacing
$topbar-margin: 4px;

// navigation spacing
$app-navigation-settings-margin: 3px;
7 changes: 6 additions & 1 deletion src/components/NcAppNavigationSettings/NcAppNavigationSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,11 @@ export default {
<style lang="scss" scoped>
#app-settings {
margin-top: auto;
padding: calc(var(--default-grid-baseline, 4px) * 2);
padding: $app-navigation-settings-margin;

&__header {
box-sizing: border-box;
margin: 0 $app-navigation-settings-margin $app-navigation-settings-margin $app-navigation-settings-margin;

.settings-button {
display: flex;
Expand Down Expand Up @@ -132,6 +133,10 @@ export default {
&__content {
display: block;
padding: 10px;

/* prevent scrolled contents from stopping too early */
margin-bottom: -$app-navigation-settings-margin;

/* restrict height of settings and make scrollable */
max-height: 300px;
overflow-y: auto;
Expand Down