Add placeholder for heading inside of app content #3957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaKirschenheuter
requested review from
artonge,
skjnldsv,
Pytal,
ShGKme and
Antreesy
3 tasks
ShGKme
reviewed
Apr 5, 2023
There was a problem hiding this comment.
According to the usage in nextcloud/photos#1727, the purpose of a new slot is to render hidden <h1 class="hidden-visually">.
In this case shouldn't it be a prop instead of a slot?
If it is a slot, then all apps developers need to pass this header with this class. What it they pass anything else?
If it is a prop, we may render it in NcAppContent as we need to.
By the way, shouldn't it have id="page-heading-level-1"?
skjnldsv
reviewed
Apr 6, 2023
raimund-schluessler
approved these changes
Apr 6, 2023
ShGKme
approved these changes
Apr 6, 2023
skjnldsv
approved these changes
Apr 6, 2023
Signed-off-by: julia.kirschenheuter <[email protected]>
JuliaKirschenheuter
force-pushed
the
fix/37174-add_placeholder_for_heading_inside_of_app_content
branch
from
b5d67aa to
8f54a71
Compare
JuliaKirschenheuter
deleted the
fix/37174-add_placeholder_for_heading_inside_of_app_content
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a possibility for providing a heading for
NcAppContent.Move
landmark instead of the<h1>heading in the<header>.By jumping directly to the h1 heading the user would be able to navigate through the main content of the page immediately.
See nextcloud/server#36911 (comment)
All apps which are using Vue for main content rendering are overriding
<main>content from https://github.com/nextcloud/server/blob/master/core/templates/layout.user.php#L91-L93. Because of it it is important to provide a possibility to place a heading in a right place.