Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow highlighted counter in app navigation #452

Merged
merged 1 commit into from
Jul 4, 2019

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jun 28, 2019

ref nextcloud/server#16076

Apps with update should have the counter inside a primary color bubble for attention

@skjnldsv please check this out, @nickvergessen helped me to fix this bug.

@GretaD GretaD requested review from nickvergessen and skjnldsv June 28, 2019 12:52
@GretaD GretaD self-assigned this Jun 28, 2019
@GretaD GretaD force-pushed the bugfix/noid/allow-highlight-counter branch from 578b6c9 to a20c210 Compare June 28, 2019 15:05
@GretaD GretaD requested a review from skjnldsv June 28, 2019 15:05
@skjnldsv
Copy link
Contributor

Indentation still off :)
Capture d’écran_2019-06-29_10-48-15

@GretaD GretaD force-pushed the bugfix/noid/allow-highlight-counter branch from a20c210 to b205ffe Compare July 4, 2019 10:42
@skjnldsv skjnldsv merged commit d0c4c48 into master Jul 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/allow-highlight-counter branch July 4, 2019 10:45
@skjnldsv skjnldsv modified the milestones: next, 0.11.5 Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants