fix(userstatus): Fix colors of user status icons #5107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
bug
|
I'm not sure if it's conflicting with nextcloud/server#42732 |
|
Okay, that is exactly my subline comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the status colors are slightly off. Most noticable on away in bright mode.
🖼️ Screenshots
If the colors are not okay, we need to change them in the original SVGs which are the ones used all over the place:
https://github.com/nextcloud/server/tree/4a08736a9bc0ff0bb2dced31c1cd2585e42d3972/apps/user_status/img
But they need to work with dark and bright mode at the same time.
🏁 Checklist