Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(richEditor): reference server-scoped regular expression to match complex user mentions + fix(richText): when parse HTML content collapse consecutive spaces #5359

Merged
merged 3 commits into from
Mar 8, 2024
Merged

fix(richEditor): reference server-scoped regular expression to match complex user mentions + fix(richText): when parse HTML content collapse consecutive spaces #5359

merged 3 commits into from
Mar 8, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 6, 2024 •
edited by ShGKme
Loading

☑️ Resolves

🖼️ Screenshots

Before After
image image

🚧 Tasks

  • Code review

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy Antreesy added enhancement New feature or request 2. developing Work in progress feature: rich-contenteditable Related to the rich-contenteditable components labels Mar 6, 2024
@Antreesy Antreesy added this to the 8.10.0 milestone Mar 6, 2024
@Antreesy Antreesy self-assigned this Mar 6, 2024
@Antreesy Antreesy force-pushed the fix/noid/mention-regex branch from 16385dd to 545724a Compare March 7, 2024 09:57
@Antreesy Antreesy marked this pull request as ready for review March 7, 2024 10:01
@Antreesy Antreesy added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 7, 2024
@Antreesy Antreesy requested review from susnux, skjnldsv and ShGKme March 7, 2024 10:01
@Antreesy Antreesy mentioned this pull request Mar 7, 2024
Closed
@Antreesy Antreesy force-pushed the fix/noid/mention-regex branch from 545724a to 18e96f6 Compare March 7, 2024 21:57
@ShGKme ShGKme force-pushed the fix/noid/mention-regex branch from 4c88612 to 0e64f2f Compare March 7, 2024 23:44
@ShGKme ShGKme changed the title fix(richEditor): reference server-scoped regular expression to match complex user mentions fix(richEditor): reference server-scoped regular expression to match complex user mentions + fix(richText): when parse HTML content collapse consecutive spaces Mar 7, 2024
@susnux susnux merged commit 6d5815f into master Mar 8, 2024
18 checks passed
@susnux susnux deleted the fix/noid/mention-regex branch March 8, 2024 09:50
@Antreesy
Copy link
Contributor Author

Antreesy commented Mar 8, 2024

/backport to next

@backportbot backportbot bot mentioned this pull request Mar 8, 2024
Merged
@ShGKme ShGKme added bug Something isn't working and removed enhancement New feature or request labels Mar 11, 2024
@ShGKme ShGKme mentioned this pull request Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme left review comments

@susnux susnux susnux approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Milestone
8.10.0
Development

Successfully merging this pull request may close these issues.

Autocomplete adds spaces before mention-parameter
4 participants
@Antreesy @susnux @juliusknorr @ShGKme