-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcActionInput): Add label to sample #5432
Conversation
/backport to next |
having labels in examples is good, but they're not passed to the NcSelect as Although NcActionInput should accept it as attribute and propagate to child component, that is not the best way, as you should check the code and guess, which props are needed, and which you should look up in another component documentation nextcloud-vue/src/components/NcSelect/NcSelect.vue Lines 1110 to 1117 in 6081376
|
Both worked in a local test (as in showed up), but yeah I seem to have missed that the console error is now back when I moved from |
Signed-off-by: Joas Schilling <[email protected]>
5af97ac
to
d5ca877
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested
☑️ Resolves
Before https://nextcloud-vue-components.netlify.app/#/Components/NcActions?id=ncactioninput yields an error in the console and leads to bad examples:
🏁 Checklist
next
requested with a Vue 3 upgrade