[NcRichText] Add style to mount point for custom picker and custom widget elements #6108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and custom wiget because mounting in vue3 does not replace the mount point but sets its innerHTML Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
requested review from
susnux,
raimund-schluessler and
juliusknorr
julien-nc
added
enhancement
susnux
approved these changes
Sep 21, 2024
juliusknorr
approved these changes
Oct 11, 2024
|
/backport to next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mounting in Vue 3 does not replace the mount point but sets its innerHTML. So the mount point needs to be styled to take all the space in its container.
This does not affect custom elements mounted with Vue 2 because the mount point is replaced so it disappears.
It will only fix custom elements mounted with Vue 3.
This can be forward-ported to next.