Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAppNavigation): RTL support #6144

Merged
merged 1 commit into from
Oct 20, 2024
Merged

fix(NcAppNavigation): RTL support #6144

merged 1 commit into from
Oct 20, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Oct 14, 2024 •
edited by susnux
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image

🚧 reproduction

  1. Change nextcloud to an Rtl language (arabic here)
  2. the toggle disappears
  3. the navigation doesn't disappear once the toggle pressed

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews labels Oct 14, 2024
@hamza221 hamza221 self-assigned this Oct 14, 2024
@ShGKme ShGKme changed the title fix: make AppNavigation functional with rtl languages fix(NcAppNavigation): RTL support Oct 14, 2024
@ShGKme ShGKme added this to the 8.19.1 milestone Oct 14, 2024
@ShGKme ShGKme added the feature: app-navigation Related to the app-navigation component label Oct 14, 2024
@susnux
Copy link
Contributor

susnux commented Oct 20, 2024

/backport to next

@susnux susnux merged commit 1eabe7e into master Oct 20, 2024
19 checks passed
@susnux susnux deleted the fix/app-navigation/rtl branch October 20, 2024 12:42
@backportbot backportbot bot mentioned this pull request Oct 20, 2024
Merged
@Antreesy Antreesy mentioned this pull request Oct 29, 2024
Merged
@Antreesy Antreesy modified the milestones: 8.19.1, 8.20.0 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@hamza221 hamza221

Labels
3. to review Waiting for reviews bug Something isn't working feature: app-navigation Related to the app-navigation component
Projects
None yet
Milestone
8.20.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hamza221 @susnux @ShGKme @Antreesy