Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move magic numbers in layout files to @dims #12

Closed
AndyScherzinger opened this issue Jun 13, 2016 · 5 comments
Closed

Move magic numbers in layout files to @dims #12

AndyScherzinger opened this issue Jun 13, 2016 · 5 comments
Labels
approved enhancement good first issue hacktoberfest low
Milestone
Nextcloud App 1.4.0

Comments

@AndyScherzinger
Copy link
Member

Actual behaviour

-many magic numbers in layout like 4dp, see review comments in #5

Expected behaviour

-move magic numbers like 4dp (widely used) to the dims.xml file as a constant
@AndyScherzinger AndyScherzinger mentioned this issue Jun 13, 2016
Merged
@ghost
Copy link

ghost commented Oct 3, 2016

Hi, I am a newbie FOSS Contributor. Can I start by contributing to this project-this bug first? Thanks!

@AndyScherzinger
Copy link
Member Author

Hi @sangeethaKP, absolutely yes! We would be happy about that contribution :)
Any questions, please let me and @tobiasKaminsky know.

divayprakash added a commit to divayprakash/android that referenced this issue Oct 6, 2016
@divayprakash
Fix magic numbers in account_action.xml nextcloud#12
1da94ff
divayprakash added a commit to divayprakash/android that referenced this issue Oct 6, 2016
@divayprakash
Fix magic numbers in account_item.xml nextcloud#12
e7114a2
divayprakash added a commit to divayprakash/android that referenced this issue Oct 6, 2016
@divayprakash
Fix magic numbers in account_setup.xml nextcloud#12
4bd89dc
divayprakash added a commit to divayprakash/android that referenced this issue Oct 6, 2016
@divayprakash
Fix magic numbers in land/account_setup.xml nextcloud#12
faca8ff
divayprakash added a commit to divayprakash/android that referenced this issue Oct 6, 2016
@divayprakash
Fix magic numbers in account_layout.xml nextcloud#12
824bf88
divayprakash added a commit to divayprakash/android that referenced this issue Oct 6, 2016
@divayprakash
Fix magic numbers in action_item.xml nextcloud#12
adf1def
divayprakash added a commit to divayprakash/android that referenced this issue Oct 6, 2016
@divayprakash
Update @Dimen in action_item.xml nextcloud#12
4ce8c61
divayprakash added a commit to divayprakash/android that referenced this issue Oct 6, 2016
@divayprakash
Update @Dimen in activity_row.xml nextcloud#12
a772bee
divayprakash added a commit to divayprakash/android that referenced this issue Oct 6, 2016
@divayprakash
Fix magic numbers in drawer_header.xml nextcloud#12
c01978d
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Update dimen in action_item.xml nextcloud#12
cce9a9c
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in activity_row.xml nextcloud#12
5902dd1
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in drawer_header.xml nextcloud#12
457a9f8
@divayprakash
Copy link
Member

Please ignore 4ce8c61, a772bee and c01978d as they have been rebased in the next 3 commits due to issues with the commit msgs.

divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in drawer_header.xml nextcloud#12
6e9c541
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in edit_share_layout.xml nextcloud#12
c232e05
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in file_actions.xml nextcloud#12
ec2bfa5
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in file_details_fragment.xml nextcloud#12
26163aa
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in file_download_fragment.xml nextcloud#12
028b934
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in file_preview.xml nextcloud#12
8ada1d1
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in files.xml nextcloud#12
ac95373
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in files_folder_picker.xml nextcloud#12
4e83a10
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in generic_explanation.xml nextcloud#12
335d140
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in listrow_details.xml nextcloud#12
f425d29
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in listrow_group.xml nextcloud#12
f2b0fb9
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in log_item.xml nextcloud#12
1e95835
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in log_send_file.xml nextcloud#12
213574f
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in media_control.xml nextcloud#12
8dcbd21
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in notification_with_progress_bar.xml nextcloud#12
3c698a7
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in participate_layout.xml nextcloud#12
41fab30
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in passcodelock.xml nextcloud#12
7d7b9cf
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in popup.xml nextcloud#12
ce9df17
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in preview_image_activity.xml nextcloud#12
7fe5e74
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in preview_image_fragment.xml nextcloud#12
b7e6c28
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in search_users_groups_layout.xml nextcloud#12
c8989af
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in share_file_layout.xml nextcloud#12
df77b29
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in share_user_item.xml nextcloud#12
2347018
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in simple_dialog_list_item.xml nextcloud#12
2a782e7
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in ssl_untrusted_cert_layout.xml nextcloud#12
544aa39
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in ssl_validator_layout.xml nextcloud#12
0564e69
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in toolbar_standard.xml nextcloud#12
c02383b
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in upload_files_layout.xml nextcloud#12
918bdd5
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in upload_list_group.xml nextcloud#12
a3ddb28
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in upload_list_item.xml nextcloud#12
d736536
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in upload_list_layout.xml nextcloud#12
db3f069
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix magic numbers in uploader_list_item_layout.xml nextcloud#12
f48b0b0
@divayprakash
Copy link
Member

@AndyScherzinger @tobiasKaminsky #12 is done!

@divayprakash divayprakash mentioned this issue Oct 7, 2016
Merged
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix errors with float values nextcloud#12
cbbea08
divayprakash added a commit to divayprakash/android that referenced this issue Oct 7, 2016
@divayprakash
Fix error in share_file_layout_text_size value nextcloud#12
2135b13
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 1.4.0 milestone Oct 9, 2016
@AndyScherzinger
Copy link
Member Author

Merged! 🚀
Again, Thanks for your contribution @divayprakash ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved enhancement good first issue hacktoberfest low
Projects
None yet
Milestone
Nextcloud App 1.4.0
Development

No branches or pull requests
2 participants
@AndyScherzinger @divayprakash