Tighter integration - Open in Notes Button #14497
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZetaTom
force-pushed
the
feature/open-in-notes
branch
3 times, most recently
from
9bbebb1 to
8c41452
Compare
Signed-off-by: ZetaTom <[email protected]>
Signed-off-by: ZetaTom <[email protected]>
Signed-off-by: ZetaTom <[email protected]>
Signed-off-by: ZetaTom <[email protected]>
Signed-off-by: ZetaTom <[email protected]>
ZetaTom
force-pushed
the
feature/open-in-notes
branch
from
8c41452 to
9d36770
Compare
ZetaTom
requested review from
jancborchardt,
tobiasKaminsky and
alperozturk96
and removed request for
Hyeyoung346
|
@jancborchardt, please review the design and placement of the new Open in Notes button. It's designed to look like the Open in Collectives button in the web interface. |
Signed-off-by: ZetaTom <[email protected]>
ZetaTom
force-pushed
the
feature/open-in-notes
branch
from
9d36770 to
ffdd1ef
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14497.apk |
There was a problem hiding this comment.
Nice! It could be improved a bit by clearly grouping it within an outlined card to separate it from the regular content.
https://m3.material.io/components/cards/overview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new Open in Notes button to folders managed by the Nextcloud Notes app. Taping on this button will open the Notes app carrying the current account over.
Screenshots
(Rich Workspace)
(Rich Workspace)
Related