Update ConnectivityServiceImpl.java #14519
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #6851 Signed-off-by: Josh <[email protected]>
|
test-Unit test failed, but no output was generated. Maybe a preliminary stage failed. |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6851
NET_CAPABILITY_NOT_RESTRICTEDis not sufficient to check if a network is metered.Checking either
NET_CAPABILITY_NOT_METEREDor callingisActiveNetworkMetered()are likely more appropriate. While we do callisNetworkActiveNetworked(), it's never executed sincegetActiveNetwork()will rarely be null.In addition,
ConnectivityManagerCompatdoesn't seem to be needed any longer since it's for API <16.TODO (out of scope for this PR): Callbacks