Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: Soften cookie #37

Merged
merged 3 commits into from
Jun 20, 2016
Merged

HOTFIX: Soften cookie #37

merged 3 commits into from
Jun 20, 2016

Conversation

tobiasKaminsky
Copy link
Member

As mentioned in nextcloud/server#110

@AndyScherzinger @przybylski please test and then we should release a 1.0.1 for this.

@AndyScherzinger
Copy link
Member

LGTM

I can't test it since the preview generation isn't working for me (on the server side / web app).

@AndyScherzinger
Copy link
Member

BTW I think if we do the release for this we can right now simply release the trunk after this is merged and moved the planned/closed PRs from https://github.com/nextcloud/android/issues?q=milestone%3A%22Nextcloud+App+1.1.0%22+is%3Aclosed to 1.0.1 so we also add some minor enhancements like the animated GIF support :)

@LukasReschke
Copy link
Member

LukasReschke commented Jun 20, 2016

LGTM

@LukasReschke LukasReschke merged commit 82a4315 into master Jun 20, 2016
@LukasReschke LukasReschke deleted the softenCookie branch June 20, 2016 14:00
@LukasReschke
Copy link
Member

LukasReschke commented Jun 20, 2016

I'm happy to push this as 1.0.1 to the appstore if you tell me what branch/tag to compile 🙈

@AndyScherzinger
Copy link
Member

@LukasReschke
Copy link
Member

Changelog:

@LukasReschke
Copy link
Member

Published to beta at https://play.google.com/apps/testing/com.nextcloud.client, will publish to prod once the pre-launch reports are done.

@LukasReschke
Copy link
Member

Also a smoke testing of the beta would be appreciated 😉

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jun 20, 2016

Update worked, can't say anything about the previews since they don't work on my server (for no reason), so I never see them, not even in the web app. Besides that it works fine. So just publish to everybody 💃

Which will happen anyways on f-droid 😉

@LukasReschke
Copy link
Member

Done, thanks a lot @AndyScherzinger and @tobiasKaminsky 🚀

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jun 20, 2016

Always a pleasure 🎉
As to the bug fix: 🙏 @tobiasKaminsky and also thanks to @przybylski for your efforts and code reviews! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants