Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling sharing via link not honored #4399

Open
pboguslawski opened this issue Jul 27, 2022 · 2 comments
Open

Disabling sharing via link not honored #4399

pboguslawski opened this issue Jul 27, 2022 · 2 comments
Labels
0. to triage Pending approval or rejection bug

Comments

@pboguslawski
Copy link
Contributor

Steps to reproduce

  1. Disable "Settings > Sharing > Allow users to share via link and emails"
  2. Calendars still allow to share it via links.

Expected behavior

Sharing calendar via link should be disabled.

Actual behaviour

Sharing calendar via link is still enabled.

Calendar app version

3.4.2

CalDAV-clients used

No response

Browser

No response

Client operating system

No response

Server operating system

No response

Web server

No response

Database engine version

No response

PHP engine version

No response

Nextcloud version

No response

Updated from an older installed version or fresh install

No response

List of activated apps

No response

Nextcloud configuration

No response

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

No response
@pboguslawski pboguslawski added 0. to triage Pending approval or rejection bug labels Jul 27, 2022
pboguslawski added a commit to ibpl/server that referenced this issue Oct 1, 2022
@pboguslawski
Disable sharing calendars via link when sharik via link is disabled
45eefc2 
This mod disallows sharing calendars via link when `shareapi_allow_links`
is disabled.

Related: nextcloud/calendar#525
Related: nextcloud/calendar#4399
Author-Change-Id: IB#1126264
Signed-off-by: Pawel Boguslawski <[email protected]>
@pboguslawski pboguslawski mentioned this issue Oct 1, 2022
Closed
pboguslawski added a commit to ibpl/calendar that referenced this issue Oct 1, 2022
@pboguslawski
Hide sharing calendar via link in UI when sharing via link is disabled
608636d 
This mod hides sharing calendar via link in UI when `shareapi_allow_links` is disabled.
Should be applied together with nextcloud/server#34372

Related: nextcloud/server#34372
Related: nextcloud#525
Related: nextcloud#4399
Author-Change-Id: IB#1126264
Signed-off-by: Pawel Boguslawski <[email protected]>
@pboguslawski pboguslawski mentioned this issue Oct 1, 2022
Closed
tcitworld pushed a commit to nextcloud/server that referenced this issue Oct 28, 2022
@pboguslawski @tcitworld
Disable sharing calendars via link when sharik via link is disabled
588574d 
This mod disallows sharing calendars via link when `shareapi_allow_links`
is disabled.

Related: nextcloud/calendar#525
Related: nextcloud/calendar#4399
Author-Change-Id: IB#1126264
Signed-off-by: Pawel Boguslawski <[email protected]>
tcitworld pushed a commit to nextcloud/server that referenced this issue Jan 20, 2023
@pboguslawski @tcitworld
Disable sharing calendars via link when sharik via link is disabled
f931259 
This mod disallows sharing calendars via link when `shareapi_allow_links`
is disabled.

Related: nextcloud/calendar#525
Related: nextcloud/calendar#4399
Author-Change-Id: IB#1126264
Signed-off-by: Pawel Boguslawski <[email protected]>
@pboguslawski
Copy link
Contributor Author

Was fixed in #5679 but still does not work because required fix was not applied to server.

@tcitworld
Copy link
Member

Fix at nextcloud/server#34873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. to triage Pending approval or rejection bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tcitworld @pboguslawski