-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix navigation toggle overlap #5391
Conversation
Signed-off-by: Jan C. Borchardt <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5391 +/- ##
=========================================
Coverage 22.74% 22.74%
Complexity 372 372
=========================================
Files 237 237
Lines 11684 11684
Branches 2270 2270
=========================================
Hits 2657 2657
Misses 9027 9027
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works. Thank you very much for fixing this ❤️
/backport to stable4.4 |
@raimund-schluessler right, good point.
Do you think this would be a proper fix or do you see any further issues with that? @ChristophWurst @st3iny @siccovansas |
I found a working solution with
|
This fixes the leftovers of nextcloud/groupware#2
The only part where this is still a problem is in month view in mobile mode, but all the rest is significantly better so I would consider it done for now.
Navigation.toggle.before.mp4
Nav.toggle.fix.mp4