Allow a calendar to be shared with circles. #602
Conversation
|
please review @daita |
|
Hey :) Thx for your pull-request! Can you please look into the failing unit tests? |
georgehrke
added
2. developing
|
@daita @viniciuscb What's the status on this? :) |
|
Looks like it works, having some GUI issue:
but it works |
|
Remember that this will needs nextcloud/server#6512 |
|
Hi @daita , progress in this review? What should I do to have this accepted? |
|
hi, |
|
It is since it needs some server changes. |
|
Hey guys. Really great that you are working on that! Really looking forward to seeing your progress soon. Your contribution is one more step towards a real collaboration platform. Cheers |
|
Is there any update on this issue? Using circles with calendar would be a really useful feature. |
We've been using this feature for more than a year in our NC implementation, already in NC14. Here, we're waiting for a review and guidelines to make it acceptable to be merged. |
|
@dtygel Did you apply any changes to nextcloud/server#6512 or are you just using it like that? |
Changes in the interface to allow: * Calendar to be shared with a circle * Show calendars (and events) that are shared with current user's circles This need that the commit f45624f1819833086368d95f0173bd55a3fb8dae is applied in nextcloud core. Signed-off-by: Vinicius Cubas Brand <[email protected]>
viniciuscb
force-pushed
the
add_circles_share
branch
from
7183028 to
8b06038
Compare
|
Using like that. Made a cherry-pick from previous commit and it worked in master. Made a new commit with current date and a more precise description. This and PR nextcloud/server#6512 were enough to allow a calendar to be shared with a circle. |
|
@georgehrke so, we will need a release of Calendar for NC16 including this PR. nextcloud/server#12119 will be merge also. |
|
@skjnldsv Mind to review this and release a new version of the app? |
|
@MorrisJobke I will review and release this weekend |
|
Works very well. @viniciuscb Thank you for this pull-request. I'm happy to finally get this in. |
|
Is this issue still open? |
The possibility to share a calendar with a circle is implemented in this commit and in commit e534c55 in nextcloud core.
There is a PR there:
nextcloud/server#6512
I've tested this functionality using nextcloud 12.