Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhanc: keep calendar always open #6322

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Sep 4, 2024

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 23.33%. Comparing base (56ee073) to head (454e65d).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/views/Appointments/Booking.vue 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6322   +/-   ##
=========================================
  Coverage     23.33%   23.33%           
  Complexity      453      453           
=========================================
  Files           248      248           
  Lines         11777    11777           
  Branches       2257     2257           
=========================================
  Hits           2748     2748           
  Misses         8705     8705           
  Partials        324      324           
Flag Coverage Δ
javascript 14.95% <0.00%> (ø)
php 59.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nimishavijay
Copy link
Member

Nice! :) Also see #6324 for how we can improve the design for this as it looks a bit outdated atm

@GretaD
Copy link
Contributor Author

GretaD commented Sep 6, 2024

@nimishavijay please have another look at the screenshot. In the appointment case, we cannot use the native datetimepicker, because the native one doesnt allow for the dropdown to be always open, because that is browser defined behavior.

I tried to adopt the normal one, as much as i could, to your mockup in the other ticket.

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good! :)

  • One of the most important improvements UX-wise is: "disable dates for which no slots are available", is that possible to grey out the dates with no slots? added them to the general list, not to be delivered with this pr
  • The time zone picker doesn’t need a full heading, or just "Time zone", not "Select a time zone"
  • The "Select a date and time slot" would be good to split, or if the time slots are shifted a bit down so it fits with the layout in @nimishavijay’s mockup
  • Regarding the third column: Currently the vertical gap seems rather large, it could be reduced a little bit
  • There can be a larger gap for every hour as a little divider. In many cases like here, there would then be slots of 4 grouped together to get a better feeling for the time rather than a long list. added them to the general list, not to be delivered with this pr

@GretaD GretaD self-assigned this Sep 10, 2024
@GretaD GretaD added 2. developing Work in progress enhancement New feature request labels Sep 10, 2024
@GretaD GretaD force-pushed the enhanc/booking-calendar-date branch from 0b4f46c to b373d5b Compare September 16, 2024 14:29
@GretaD GretaD force-pushed the enhanc/booking-calendar-date branch from b373d5b to 17a54a6 Compare November 18, 2024 12:43
@GretaD GretaD requested a review from jancborchardt November 18, 2024 12:43
@GretaD GretaD marked this pull request as ready for review November 18, 2024 13:15
@GretaD GretaD added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 18, 2024
@SebastianKrupinski
Copy link
Contributor

Tested. Looks and works great

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

Looks a bit weird on dark mode though but I think that's a problem in the upstream date picker component.

image

@GVodyanov
Copy link
Contributor

GVodyanov commented Nov 25, 2024

Yeah it's the same now even without this PR, I just discovered it, I will open an issue for it.

image

#6521

@SebastianKrupinski
Copy link
Contributor

Yeah it's the same now even without this PR, I just discovered it, I will open an issue for it.

Yeah, I noticed that and thought it was a new feature!

@st3iny
Copy link
Member

st3iny commented Nov 25, 2024

Yeah it's the same now even without this PR, I just discovered it, I will open an issue for it.

Yeah, I noticed that and thought it was a new feature!

Can't click the dates if you can't seem em 😆

@GretaD GretaD force-pushed the enhanc/booking-calendar-date branch from 17a54a6 to 454e65d Compare November 28, 2024 14:18
@GretaD GretaD enabled auto-merge November 28, 2024 14:19
@GretaD GretaD merged commit 4e665c3 into main Nov 28, 2024
36 of 37 checks passed
@GretaD GretaD deleted the enhanc/booking-calendar-date branch November 28, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use calendly design and layout
6 participants