feat(editor): improve attendee and resource status display #6520
+177
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
added
3. to review
st3iny
requested review from
SebastianKrupinski and
tcitworld
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6520 +/- ##
============================================
- Coverage 22.99% 22.97% -0.03%
Complexity 475 475
============================================
Files 252 252
Lines 12117 12128 +11
Branches 2315 2317 +2
============================================
Hits 2786 2786
- Misses 9004 9015 +11
Partials 327 327
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
the status icon is not aligned properly, it should be same everywhere. I remembered i fixed it here: #6580 |
|
@GretaD try updating the branch locally. The last commit here appears to be older than the merge commit of your fix. |
st3iny
force-pushed
the
feat/editor/attendee-status
branch
from
2f8a224 to
ec5076f
Compare
Is fixed by a rebase. I tested it locally again. |
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
feat/editor/attendee-status
branch
from
ec5076f to
9c23ed8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4983
I refactored the logic and moved it to a computed prop to facilitate making use of the schedule status as well.
I also implemented some custom status messages if the scheduling fails for some reason (statuses
3.xand5.x).Screenshots
Organizer's view
(In the example above, the user
testwas just added and the event was not saved yet. The same applies to the resourceCroc.)Attendee's view