Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simple calendar view width #6626

Merged
merged 1 commit into from
Jan 17, 2025
Merged

fix: simple calendar view width #6626

merged 1 commit into from
Jan 17, 2025

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jan 14, 2025

fixes #6625

Screenshot from 2025-01-14 11-03-09

@GretaD GretaD added the 3. to review Waiting for reviews label Jan 14, 2025
@GretaD GretaD self-assigned this Jan 14, 2025
@GretaD GretaD requested a review from GVodyanov January 14, 2025 10:04
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.01%. Comparing base (1d63a89) to head (27d7852).
Report is 26 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6626      +/-   ##
============================================
- Coverage     23.17%   23.01%   -0.17%     
- Complexity      472      475       +3     
============================================
  Files           250      252       +2     
  Lines         12020    12107      +87     
  Branches       2296     2318      +22     
============================================
  Hits           2786     2786              
- Misses         8907     8994      +87     
  Partials        327      327              
Flag Coverage Δ
javascript 14.54% <ø> (-0.13%) ⬇️
php 59.30% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GretaD
Copy link
Contributor Author

GretaD commented Jan 14, 2025

@GVodyanov you changed the max-width to unset. Do you remember why you did that? Also the reason why its smaller now, its because of the min-width you added in the same class, can we have the min-width bigger?

@GretaD GretaD added the bug label Jan 14, 2025
@GVodyanov
Copy link
Contributor

@GVodyanov you changed the max-width to unset. Do you remember why you did that? Also the reason why its smaller now, its because of the min-width you added in the same class, can we have the min-width bigger?

Hey! Yeah this was a result of the timepicker change, Nimisha asked to have the modal be a dynamic width
#6423 (comment)
#6385 (comment)

We can certainly change the sizes if you want, just wanted to show why we have it the way it is now. Maybe it would be better to ask Nimisha before changing though.

@GretaD
Copy link
Contributor Author

GretaD commented Jan 14, 2025

@GVodyanov you changed the max-width to unset. Do you remember why you did that? Also the reason why its smaller now, its because of the min-width you added in the same class, can we have the min-width bigger?

Hey! Yeah this was a result of the timepicker change, Nimisha asked to have the modal be a dynamic width #6423 (comment) #6385 (comment)

We can certainly change the sizes if you want, just wanted to show why we have it the way it is now. Maybe it would be better to ask Nimisha before changing though.

yes, but that broke those field so, we should have a better solution for dynamic fields. Only have those for editing state for example and not on viewing mode

@GVodyanov
Copy link
Contributor

Sure that sounds like a good idea

@ChristophWurst
Copy link
Member

Is this ready for testing and review?

@GretaD
Copy link
Contributor Author

GretaD commented Jan 16, 2025

Is this ready for testing and review?

yes, if we only want to fix the width. But, i opened another ticket to improve simple editor for other issues too.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@GretaD
Copy link
Contributor Author

GretaD commented Jan 17, 2025

i would say lets merge this one and then work on the rest whenever we pickup the overview ticket, since there are too many people who noticed the issue.

@GretaD GretaD merged commit f605392 into main Jan 17, 2025
37 of 38 checks passed
@GretaD GretaD deleted the fix/editsimple-view-mode branch January 17, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Location and description with long text, in viewing mode doesn wrap
4 participants