-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: simple calendar view width #6626
Conversation
Signed-off-by: greta <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6626 +/- ##
============================================
- Coverage 23.17% 23.01% -0.17%
- Complexity 472 475 +3
============================================
Files 250 252 +2
Lines 12020 12107 +87
Branches 2296 2318 +22
============================================
Hits 2786 2786
- Misses 8907 8994 +87
Partials 327 327
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@GVodyanov you changed the max-width to unset. Do you remember why you did that? Also the reason why its smaller now, its because of the min-width you added in the same class, can we have the min-width bigger? |
Hey! Yeah this was a result of the timepicker change, Nimisha asked to have the modal be a dynamic width We can certainly change the sizes if you want, just wanted to show why we have it the way it is now. Maybe it would be better to ask Nimisha before changing though. |
yes, but that broke those field so, we should have a better solution for dynamic fields. Only have those for editing state for example and not on viewing mode |
Sure that sounds like a good idea |
Is this ready for testing and review? |
yes, if we only want to fix the width. But, i opened another ticket to improve simple editor for other issues too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works.
i would say lets merge this one and then work on the rest whenever we pickup the overview ticket, since there are too many people who noticed the issue. |
fixes #6625