Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: free busy not updating date #6690

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

GVodyanov
Copy link
Contributor

Fix #6660

I think this comes from an unfound bug in the Pinia migration

Signed-off-by: Grigory Vodyanov <[email protected]>
@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Feb 2, 2025
@GVodyanov GVodyanov self-assigned this Feb 2, 2025
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 23.00%. Comparing base (056a8aa) to head (3b2d626).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/store/calendarObjectInstance.js 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6690   +/-   ##
=========================================
  Coverage     23.00%   23.00%           
  Complexity      475      475           
=========================================
  Files           252      252           
  Lines         12112    12110    -2     
  Branches       2310     2311    +1     
=========================================
  Hits           2786     2786           
+ Misses         8999     8998    -1     
+ Partials        327      326    -1     
Flag Coverage Δ
javascript 14.54% <0.00%> (+<0.01%) ⬆️
php 59.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test but looks good.

@st3iny
Copy link
Member

st3iny commented Feb 3, 2025

/backport to stable5.1

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Feb 3, 2025
@st3iny st3iny added this to the v5.2.0 milestone Feb 3, 2025
@st3iny st3iny merged commit cb55915 into main Feb 3, 2025
46 of 47 checks passed
@st3iny st3iny deleted the fix/free-busy-not-updating-date branch February 3, 2025 10:19
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing the free/busy modal doesn't update time in sidebar
3 participants