[stable5.0] fix(calendar-list): restrict calendar visibility toggle to checkbox only #6692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
backportbot
bot
requested review from
SebastianKrupinski,
st3iny and
tcitworld
as code owners
backportbot
bot
added
3. to review
st3iny
approved these changes
Feb 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stable5.0 #6692 +/- ##
=============================================
+ Coverage 15.40% 15.41% +0.01%
=============================================
Files 206 206
Lines 9458 9451 -7
Branches 2195 2203 +8
=============================================
Hits 1457 1457
+ Misses 7683 7675 -8
- Partials 318 319 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Previously, clicking anywhere on the calendar name would toggle its visibility, leading to accidental hiding of calendars. Now the visibility can only be toggled by clicking the checkbox/bullet icon. Fixes #3027 Signed-off-by: Antonia Schwennesen <[email protected]>
The enabled state cannot be persisted in public views, so the toggle functionality should not be available. Remove click handler from bullet icon to prevent misleading interaction. Co-authored-by: Richard Steinmetz <[email protected]> Signed-off-by: Antonia Schwennesen <[email protected]>
st3iny
force-pushed
the
backport/6681/stable5.0
branch
from
bcf8643 to
d94ca1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #6681