Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(CI): Update master php testing versions and workflow templates #1237

Closed
wants to merge 1 commit into from
Closed

chore(CI): Update master php testing versions and workflow templates #1237

wants to merge 1 commit into from

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling [email protected]

@nickvergessen nickvergessen mentioned this pull request Jan 16, 2023
Closed
64 tasks
@come-nc
Copy link
Contributor

come-nc commented Jan 23, 2023 

ERROR: RedundantCondition - lib/Tools/Traits/TNCLogger.php:195:7 - Type Psr\Log\LoggerInterface for $this->logger is always isset (see https://psalm.dev/122)
26
		if (isset($this->logger) && $this->logger instanceof LoggerInterface) {

@come-nc come-nc requested a review from ArtificialOwl January 23, 2023 09:10
@blizzz blizzz added this to the Nextcloud 29 milestone Nov 23, 2023
@nickvergessen
Copy link
Member Author

Closing before this turns 1y

@nickvergessen nickvergessen deleted the update-master-php-testing-versions branch December 19, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

Assignees

@ArtificialOwl ArtificialOwl

Labels
3. to review
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @come-nc @ArtificialOwl @blizzz