-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace logger #251
fix: replace logger #251
Conversation
Thank you for your contribution! ❤️ First of all, please note that You can ignore the failing CI, just wanted to see whether it's more broken than last time I checked - it indeed is. If you're willing to invest more time nevertheless, can you please rebase on the |
The previowus logger approach was removed at Nextcloud 30 and was needed to be replaced by Psr\Log\LoggerInterface Signed-off-by: Vitor Mattos <[email protected]>
8ac9fe3
to
e61d18c
Compare
The previowus logger approach was removed at Nextcloud 30 and was needed to be replaced by Psr\Log\LoggerInterface Signed-off-by: Vitor Mattos <[email protected]>
Last changes:
|
This comment was marked as outdated.
This comment was marked as outdated.
Did you check these? If yes, I'll merge it right away. Thanks again for your contribution! 👍 |
Yes, I didn't made smoke test looking all places of code that use the old log interface, but the piece of code that I tested worked fine and because this I made the replace at all places. I took care to check the name of methods, because this the place that the code used LogException method, I replaced by a most similar method from LoggerInterface, the other places, the method called have the same name. |
Alright, thanks again for your contribution! 👍 |
The previous logger approach was removed at Nextcloud 30 and was needed to be replaced by Psr\Log\LoggerInterface
This PR fix: