fix: Proper rich object formats

Signed-off-by: Julius Knorr <[email protected]>
nextcloud · Jan 2, 2025 · 59fa3cd · 59fa3cd
1 parent bdaf28e
commit 59fa3cd
Showing 1 changed file with 14 additions and 14 deletions.
diff --git a/lib/Activity/DeckProvider.php b/lib/Activity/DeckProvider.php
@@ -109,7 +109,7 @@ public function parse($language, IEvent $event, ?IEvent $previousEvent = null):
 			}
 			$board = [
 				'type' => 'highlight',
-				'id' => $event->getObjectId(),
+				'id' => (string)$event->getObjectId(),
 				'name' => $event->getObjectName(),
 				'link' => $this->deckUrl('/board/' . $event->getObjectId()),
 			];
@@ -126,7 +126,7 @@ public function parse($language, IEvent $event, ?IEvent $previousEvent = null):
 			}
 			$card = [
 				'type' => 'highlight',
-				'id' => $event->getObjectId(),
+				'id' => (string)$event->getObjectId(),
 				'name' => $event->getObjectName(),
 			];
 
@@ -213,7 +213,7 @@ private function parseParamForBoard($paramName, $subjectParams, $params) {
 		if (array_key_exists($paramName, $subjectParams)) {
 			$params[$paramName] = [
 				'type' => 'highlight',
-				'id' => $subjectParams[$paramName]['id'],
+				'id' => (string)$subjectParams[$paramName]['id'],
 				'name' => $subjectParams[$paramName]['title'],
 				'link' => $this->deckUrl('/board/' . $subjectParams[$paramName]['id'] . '/'),
 			];
@@ -224,7 +224,7 @@ private function parseParamForStack($paramName, $subjectParams, $params) {
 		if (array_key_exists($paramName, $subjectParams)) {
 			$params[$paramName] = [
 				'type' => 'highlight',
-				'id' => $subjectParams[$paramName]['id'],
+				'id' => (string)$subjectParams[$paramName]['id'],
 				'name' => $subjectParams[$paramName]['title'],
 			];
 		}
@@ -235,7 +235,7 @@ private function parseParamForAttachment($paramName, $subjectParams, $params) {
 		if (array_key_exists($paramName, $subjectParams)) {
 			$params[$paramName] = [
 				'type' => 'highlight',
-				'id' => $subjectParams[$paramName]['id'],
+				'id' => (string)$subjectParams[$paramName]['id'],
 				'name' => $subjectParams[$paramName]['data'],
 				'link' => $this->urlGenerator->linkToRoute('deck.attachment.display', ['cardId' => $subjectParams['card']['id'], 'attachmentId' => $subjectParams['attachment']['id']]),
 			];
@@ -259,7 +259,7 @@ private function parseParamForLabel($subjectParams, $params) {
 		if (array_key_exists('label', $subjectParams)) {
 			$params['label'] = [
 				'type' => 'highlight',
-				'id' => $subjectParams['label']['id'],
+				'id' => (string)$subjectParams['label']['id'],
 				'name' => $subjectParams['label']['title']
 			];
 		}
@@ -278,7 +278,7 @@ private function parseParamForAcl($subjectParams, $params) {
 			} else {
 				$params['acl'] = [
 					'type' => 'highlight',
-					'id' => $subjectParams['acl']['participant'],
+					'id' => (string)$subjectParams['acl']['participant'],
 					'name' => $subjectParams['acl']['participant']
 				];
 			}
@@ -294,7 +294,7 @@ private function parseParamForComment($subjectParams, $params, IEvent $event) {
 				$event->setParsedMessage($comment->getMessage());
 				$params['comment'] = [
 					'type' => 'highlight',
-					'id' => $subjectParams['comment'],
+					'id' => (string)$subjectParams['comment'],
 					'name' => $comment->getMessage()
 				];
 			} catch (NotFoundException $e) {
@@ -343,22 +343,22 @@ private function parseParamForChanges($subjectParams, $params, $event) {
 		if (array_key_exists('before', $subjectParams)) {
 			$params['before'] = [
 				'type' => 'highlight',
-				'id' => $subjectParams['before'],
-				'name' => $subjectParams['before']
+				'id' => (string)$subjectParams['before'],
+				'name' => $subjectParams['before'] ?? ''
 			];
 		}
 		if (array_key_exists('after', $subjectParams)) {
 			$params['after'] = [
 				'type' => 'highlight',
-				'id' => $subjectParams['after'],
-				'name' => $subjectParams['after']
+				'id' => (string)$subjectParams['after'],
+				'name' => $subjectParams['after'] ?? ''
 			];
 		}
 		if (array_key_exists('card', $subjectParams) && $event->getSubject() === ActivityManager::SUBJECT_CARD_UPDATE_TITLE) {
 			$params['card'] = [
 				'type' => 'highlight',
-				'id' => $subjectParams['after'],
-				'name' => $subjectParams['after']
+				'id' => (string)$subjectParams['after'],
+				'name' => $subjectParams['after'] ?? ''
 			];
 		}
 		return $params;