Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserted Images render in Editor #2567

Closed
reox opened this issue Nov 17, 2020 · 4 comments · Fixed by #2588
Closed

Inserted Images render in Editor #2567

reox opened this issue Nov 17, 2020 · 4 comments · Fixed by #2588

Comments

@reox
Copy link
Contributor

reox commented Nov 17, 2020

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Describe the bug

When inserting an image in the description, it should only be visible by the markdown text.
Since 1.2.0, it also shows as image in the editor and the editor freaks out if you want to select the markdown link.
You can not delete the text, because the cursor jumps all over the place, selecting text with the mouse is impossible.
Inserting an image (or having a card with an inserted image) makes it impossible to edit the card details below the image, because the image seems to mess up the lines. When clicking below the image into text, the cursor position does not coincide with the position where you start editing.

Furthermore, when I want to click on the Arrow to insert the attachment, the info dialog pops up and renders over the button. The mouse pointer changes from pointer to finger and back every split second. I have furiously click and try to hit the button in order to insert the image. (that might be worth another bug report though)

To Reproduce
Steps to reproduce the behavior:

  1. Create card
  2. Upload image
  3. edit description
  4. insert image

Expected behavior

The editor mode should only show the markdown link.

Screenshots
If applicable, add screenshots to help explain your problem.
image

Client details:

  • OS: Win10
  • Browser: Firefox
  • Version: 82.0.3
  • Device: Desktop

Also on

  • OS: CentOS
  • Browser: FF

NC 19.0.4 / Deck 1.2.0

@stefan-niedermann

This comment has been minimized.

@reox

This comment has been minimized.

@BKapelari
Copy link
Contributor

BKapelari commented Nov 18, 2020

Addition: In my case, the content of the editor doesn't save. If I leave the modal and reopen it, the image is gone. The only way to get it work was: Copy all (cmd + a), close the modal, reopen it an paste the content.

Deck Version: 1.2.1
Nextcloud Version: 19.0.4
Browser: FireFox 83.0 on MacOS 10.15.7

@reox
Copy link
Contributor Author

reox commented Nov 18, 2020

@BKapelari I wrote in #2484 that there is a workaround for that:
If an attachment is inserted and the editor is left, it does not save. However, if you edit the description after adding the attachment it saves it (at least so far...) But there are also other reports that the description field is broken right now :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants