Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

card collections/dashboard #1319

Closed
wants to merge 3 commits into from
Closed

card collections/dashboard #1319

wants to merge 3 commits into from

Conversation

jakobroehrl
Copy link
Contributor

Signed-off-by: Jakob [email protected]

  • Target version: vue

Added some collections, and it's working so far :)
Could you give me your feedback @juliushaertl ?

  • There is now redundant code from the card view
  • The Router could be better, I think
  • Fetching the data is not really fast, should I try to solve this on the server or client side?
  • Any ideas how to change the code, if we have filtering and searching in mind?

Thanks a lot! :)

I think I would use this view in #1315, too.

grafik

@jakobroehrl jakobroehrl changed the title add card collections card collections/dashboard Nov 2, 2019
@jancborchardt
Copy link
Member

Nice! :) Some design feedback:

  • The counters of "Due soon" and "Assigned to you" should use the counter on the right of the row as defined in the component
  • No categorization and indentation is needed. Simply do a flat list with
    • Due soon
    • Assigned to you (we always use "you", never "me" in the interface)
    • All cards
      space
    • Board 1
    • Board 2

@ardarandir
Copy link

Hi, we would love this collections/dashboard feature to go live for productive use. I don't quite get when we can expect that to happen. Would you be so kind as to give me any kind of estimation? We are using Deck 0.7.0 on Nextcloud 17 (stable). Thanks in advance!

@jakobroehrl
Copy link
Contributor Author

Hi, we would love this collections/dashboard feature to go live for productive use. I don't quite get when we can expect that to happen. Would you be so kind as to give me any kind of estimation? We are using Deck 0.7.0 on Nextcloud 17 (stable). Thanks in advance!

@ardarandir
We have to finish the vue migration first. There is no progress it the last weeks because of other priorities. Sorry, can't give a an estimation. Would love to see this feature, too :)

@juliusknorr
Copy link
Member

In addition to the comments by @jancborchardt I think we should try to keep the main content view stay in a similar card based layout as the regular board view has.

I don't see a good use case for an all cards view, as this would basically be just a long endless list without any proper filtering. We should aim to provide lists that give users a good overview or help them to find the relevant cards more easily.

Due date view

Frame 5

The assigned to me list could also be grouped by duedates, as this is most likely what the priorization is done by. In addition we could allow users to apply custom filters on those lists with #414

cc @nextcloud/designers

@juliusknorr juliusknorr changed the base branch from vue to master January 25, 2020 09:51
@juliusknorr juliusknorr force-pushed the cardCollections branch 2 times, most recently from 9e4415d to f5eae04 Compare January 25, 2020 09:51
@juliusknorr
Copy link
Member

Rebased and changed base branch to master

jakobroehrl and others added 2 commits January 25, 2020 13:50
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
@jakobroehrl jakobroehrl self-assigned this Jan 31, 2020
@alexanderdd
Copy link

alexanderdd commented Feb 22, 2020

Not sure how you resolve conflicting feedback around here?
Personally, I agree with #1319 (comment) and while I think #1319 (comment) has a good point, I think this should not stand in the way of merging this pull request.

Or is the only thing missing now the "Review required"?

Thanks.

@alexanderdd alexanderdd mentioned this pull request Feb 22, 2020
@juliusknorr
Copy link
Member

Or is the only thing missing now the "Review required"?

No, we definitely should address the mentioned points before merging. 😉

@juliusknorr
Copy link
Member

Not sure how you resolve conflicting feedback around here?

Let's see if @jancborchardt and @nextcloud/designers have any comments on my additions.

@jancborchardt
Copy link
Member

Agree with everything said by @juliushaertl in #1319 (comment) :)

Only thing is that I’m not sure the list layout should use the card style, as that’s too many containers for a single-row layout. I tend towards doing it like @jakobroehrl above or as in the Tasks app.

cc @raimund-schluessler as this now gets very close into the same territory as Tasks and we should coordinate how best to move forward together. :) As @jakobroehrl mentioned, the other tools all go in the direction of just having views for the "to dos", instead of different apps: See Microsoft Tasks in Teams, Asana, Ticktick, Todoist, Ora, Zenkit, …

@raimund-schluessler

This comment has been minimized.

@juliusknorr

This comment has been minimized.

@georgehrke

This comment has been minimized.

@juliusknorr
Copy link
Member

Back to the original topic of the pull request, I would suggest we go for a card based approach as well for now, as once boards are exposed as calendars with #1545 we could redirect the user to the tasks app showing the cards in a list as a first starting point.

@BKapelari

This comment has been minimized.

@jakobroehrl
Copy link
Contributor Author

There are a lot of the same functionality in Deck and Tasks eg:

  • assign to user
  • share with user, group, circle
  • comments
  • attachments
  • tags
  • activity
  • due dates
  • filter, sort
  • collections (dueToday, assignToMe, ...)

I think it's easier to interate a list/table view in Deck than duplicate and maintain the hole functionality in two apps.

@BKapelari

This comment has been minimized.

@jakobroehrl

This comment has been minimized.

@raimund-schluessler

This comment has been minimized.

@juliusknorr juliusknorr mentioned this pull request Mar 2, 2020
3 tasks
@alexanderdd
Copy link

alexanderdd commented Mar 8, 2020

So what will happen to this pull request? Merge or decline (if thats the right word)?

Path1
@juliushaertl proposed to use a card layout instead #1319 (comment)

Path2
@jancborchardt - I thi k he said he likes the row style as proposed in this pull request, but some minor improvements are needed (these #1319 (comment))

Which path will we continue? (I am never sure how decisions are made here...)

@juliusknorr
Copy link
Member

So what will happen to this pull request? Merge or decline (if thats the right word)?

Well, the discussion drove a bit into details that are actually part of #15 but are of course related to the lists. My comment from #1319 (comment) still stands. So with that and the plan we came up with in #15 I think reusing the tasks app for any list view would make the most sense here.

Which path will we continue? (I am never sure how decisions are made here...)

We usually try to find a solution that is somehow common sense in the end. Let me quote our code of conduct here:

Be pragmatic
Nextcloud is a pragmatic community. We value tangible results over having the last word in a discussion. We defend our core values like freedom and respectful collaboration, but we don't let arguments about minor issues get in the way of achieving more important results. We are open to suggestions and welcome solutions regardless of their origin. When in doubt support a solution which helps getting things done over one which has theoretical merits, but isn't being worked on. Use the tools and methods which help getting the job done. Let decisions be taken by those who do the work.
https://nextcloud.com/contribute/code-of-conduct/

@juliusknorr
Copy link
Member

I think we drifted away from what this pull request was actually about - the dashboard to give quick access to important cards.

Let me summarize what I think the consent was:

  • Due dates - A column view makes most sense here as we can have the due date categorization as different columns here.

  • All cards - does not have a real use case -> Let's remove that one

Open questions:

Assigned to me

Only thing is that I’m not sure the list layout should use the card style, as that’s too many containers for a single-row layout. I tend towards doing it like @jakobroehrl above or as in the Tasks app.

I was not arguing for a single row layout but to still provide some sort of grouping for the dashboard overview, like this:

The assigned to me list could also be grouped by duedates, as this is most likely what the priorization is done by.

@juliusknorr
Copy link
Member

Continued in #1934

@juliusknorr juliusknorr deleted the cardCollections branch June 18, 2020 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants