show card details in modal

[jakobroehrl]

Signed-off-by: Jakob Röhrl [email protected]

• Target version: master

[stefan-niedermann]

May i ask what the intention of this modal is?
Is it to enable a user to edit distraction-free?
Because if the intention is to give the user more space to edit and view the description - it's not that much difference yet 😉

[jakobroehrl]

May i ask what the intention of this modal is?
Is it to enable a user to edit distraction-free?
Because if the intention is to give the user more space to edit and view the description - it's not that much difference yet 😉

Sure!

• more space and distraction-free editing
• use it for showing the content of archived cards

[juliusknorr]

• Modal text should not be centered - I assume there is a to wide css rule somewhere
• Check how multiple modals behave e.g. when adding an attachment
• Move the action to the sidebar actions menu
• The sidebar should not be shown if the modal is used (open it directly from the board view)
• Persist state of cardDetailsInModal in browser local storage
• Show activity/attachments/comments in the modal. This is especially required for showing archived cards
• description, users and tags are not updated in the sidebar
• Add a button to the modal to switch back to the sidebar view
• Fix styling in the modal view, not sure if this works properly with just reusing the sidebar view or of we need to come up with our own tab implementation, but the first should of course be preferred
• In a second step we could allow users to use the modal as a default opener

[juliusknorr]

@jakobroehrl I took the liberty to push two commits that I came up with when trying out your branch. This basically makes sure that the modal can be properly reopened and in the same run adds a checkbox to toggle between default open for the sidebar and default open the modal. I've added another TODO to the above list for persisting that state.

[jakobroehrl]

Fix styling in the modal view, not sure if this works properly with just reusing the sidebar view or of we need to come up with our own tab implementation, but the first should of course be preferred

@juliushaertl To do this, we need to remove the following CSS style from the sidebar: width, max-width, border-left
Is this possible?

[juliusknorr]

@juliushaertl To do this, we need to remove the following CSS style from the sidebar: width, max-width, border-left Is this possible?

Yes, i think for that we can just overwrite the styles with a v-deep selector in in the modal.

[jakobroehrl]

@juliushaertl
This does work if I add it here:

deck/src/App.vue

Lines 111 to 115 in f93be51

	.app-sidebar::v-deep {
	border-left: 0;
	width: 800px;
	max-width: 780px;
	top: 0px;

But it affects all sidebars as well, how can we change this?

[juliusknorr]

Pushed the rebased version and removed the for now unneeded details tab component. Let's keep the changes minimal for now.

@jakobroehrl Mabye you can have another look at the modal styling, the scrollbar looks out of place:

[jakobroehrl]

@juliushaertl
Thanks for your commit, let's merge this PR!

[juliusknorr]

Changes are good to go from my side now 👍

@jakobroehrl Mind to make sure that CI passes? 😉