Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve filter popover accessibility #3820

Merged
merged 1 commit into from
May 18, 2022
Merged

Improve filter popover accessibility #3820

merged 1 commit into from
May 18, 2022

Conversation

juliusknorr
Copy link
Member

Fix #3819

  • Ensure the popover has a proper size on smaller window heights
  • Move the popover next to the button to fix the focus order of elements
  • Move clear filters button to use the @nextcloud/vue Button component

@cypress
Copy link

cypress bot commented May 13, 2022



Test summary

5 0 0 0


Run details

Project deck
Status Passed
Commit 67e66231c3 ℹ️
Started May 13, 2022 10:47 AM
Ended May 13, 2022 10:48 AM
Duration 01:34 💡
OS Linux Ubuntu - 20.04
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@juliusknorr juliusknorr self-assigned this May 13, 2022
@juliusknorr juliusknorr merged commit 9db8f9c into master May 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the bugfix/3819 branch May 18, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Filter popover accessibility
2 participants