Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update signature of Entity::markFieldUpdated #4398

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Update signature of Entity::markFieldUpdated #4398

merged 1 commit into from
Jan 24, 2023

Conversation

nickvergessen
Copy link
Member

Ref nextcloud/server@e91457d

Summary

PHP Fatal error:  Declaration of OCA\Deck\Db\RelationalEntity::markFieldUpdated($attribute) must be compatible with OCP\AppFramework\Db\Entity::markFieldUpdated(string $attribute): void in /var/www/html/apps/deck/lib/Db/RelationalEntity.php on line 56
PHP Fatal error:  Declaration of OCA\Deck\Db\RelationalEntity::markFieldUpdated($attribute) must be compatible with OCP\AppFramework\Db\Entity::markFieldUpdated(string $attribute): void in /var/www/html/apps/deck/lib/Db/RelationalEntity.php on line 56
PHP Fatal error:  Declaration of OCA\Deck\Db\RelationalEntity::markFieldUpdated($attribute) must be compatible with OCP\AppFramework\Db\Entity::markFieldUpdated(string $attribute): void in /var/www/html/apps/deck/lib/Db/RelationalEntity.php on line 56

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@nickvergessen nickvergessen self-assigned this Jan 23, 2023
tobiasKaminsky
tobiasKaminsky approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with latest master

@nickvergessen
Copy link
Member Author

7.4 will be fixed in #4389

@nickvergessen nickvergessen merged commit 5ec251e into main Jan 24, 2023
@delete-merged-branch delete-merged-branch bot deleted the techdebt/noid/update-signature-of-markFieldUpdated branch January 24, 2023 07:37
@juliusknorr juliusknorr mentioned this pull request Aug 22, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud luka-nextcloud is a code owner

Assignees

@nickvergessen nickvergessen

Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @juliusknorr @tobiasKaminsky