Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #5451 #5455

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

mintsoft
Copy link

@mintsoft mintsoft commented Jan 11, 2024

Resolves: #5451

  • Resolves: #
  • Target version: main

Summary

No longer checks if it is compact before applying the due vue as it is handled internally anyway

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@mintsoft mintsoft changed the title Fixing Previously in compact mode, if there was no due date ever set Fixing #5451 Jan 11, 2024
and the card was marked as complete, you could not see the tick

Signed-off-by: Rob Emery <[email protected]>
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix ❤️

@juliusknorr juliusknorr merged commit ec563a3 into nextcloud:main Jan 12, 2024
25 checks passed
@juliusknorr
Copy link
Member

/backport to stable28

@mintsoft mintsoft deleted the fix-compact-done-icon-5451 branch January 12, 2024 08:12
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon for done cards in compact mode without due date
2 participants