Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up unused indicies #5612

Merged
merged 2 commits into from
May 9, 2024
Merged

Cleaning up unused indicies #5612

merged 2 commits into from
May 9, 2024

Conversation

mintsoft
Copy link

@mintsoft mintsoft commented Feb 22, 2024 •
edited
Loading

Summary

Adding migration to cleanup these unused indicies; I have absolutely no idea what is going on with the naming convention on the filename/class so I've made something up.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@mintsoft mintsoft changed the title Cleaning up unused indicies, fixes #5520 Cleaning up unused indicies Feb 22, 2024
juliusknorr
juliusknorr requested changes Feb 29, 2024
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I left two small comments, maybe you can adjust that.

In addition please also comment out the index creation in the original migrations so that on new installations we do not need to run those.

lib/Migration/Version11000Date20240222115515.php Outdated Show resolved Hide resolved
lib/Migration/Version11000Date20240222115515.php Outdated Show resolved Hide resolved
@mintsoft
Copy link
Author

All done

@mintsoft mintsoft requested a review from juliusknorr March 8, 2024 16:25
@mintsoft
Copy link
Author

mintsoft commented May 2, 2024

@juliushaertl polite reminder about this PR, I've just rebased and such so it's ready

@mintsoft @juliusknorr
Applying variable naming scheme, returning schema only if changes are…
afb5057 
… made for performance and removing the original

creation of the indicies for new installations

Signed-off-by: Rob Emery <[email protected]>
@juliusknorr juliusknorr merged commit 1f20554 into nextcloud:main May 9, 2024
31 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees
No one assigned
Labels
2. developing bug feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redundant database indices
2 participants
@mintsoft @juliusknorr