Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change import command's config default argument #5722

Merged
merged 2 commits into from
May 9, 2024

Conversation

JimMadge
Copy link
Contributor

@JimMadge JimMadge commented Mar 31, 2024

Summary

  • Change the default argument of deck:import --config ... from config.json to null.
    This default value caused a problem (Support migration of user data #5235) where if not config was supplied, config.json is not found and the message "It's not a valid config file" is shown (deck:import misleading error message for config.json #5213)
  • Change the deck:import --data ... option to VALUE_REQUIRED. From reading the Symfony docs I think all options are optional. VALUE_OPTIONAL lets you include the option in a command line without giving a value, e.g. deck:import --data would be valid.

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
    • Is this n/a as there are no new features?
  • Documentation (manuals or wiki) has been updated or is not required
    • I think this should be consistent with the current docs, where not providing --config assumes the data is a deck json.

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request. 👍

@juliusknorr juliusknorr merged commit e9d1e93 into nextcloud:main May 9, 2024
31 checks passed
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support migration of user data
2 participants