Change import command's config default argument #5722
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
deck:import --config ...
fromconfig.json
tonull
.This default value caused a problem (Support migration of user data #5235) where if not config was supplied,
config.json
is not found and the message "It's not a valid config file" is shown (deck:import misleading error message for config.json #5213)deck:import --data ...
option toVALUE_REQUIRED
. From reading the Symfony docs I think all options are optional.VALUE_OPTIONAL
lets you include the option in a command line without giving a value, e.g.deck:import --data
would be valid.TODO
Checklist
--config
assumes the data is a deck json.