Improve initialisation of C++ FileProvider class

Signed-off-by: Claudio Cambra <[email protected]>
nextcloud · Mar 15, 2023 · 857df97 · 857df97
1 parent 9f0ce59
commit 857df97
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 4 deletions.
diff --git a/src/gui/application.cpp b/src/gui/application.cpp
@@ -387,7 +387,7 @@ Application::Application(int &argc, char **argv)
     }
 
 #ifdef Q_OS_MACOS
-    _fileProvider.reset(Mac::FileProvider::instance());
+    _fileProvider.reset(new Mac::FileProvider);
 #endif
 
     FolderMan::instance()->setSyncEnabled(true);

diff --git a/src/gui/macOS/fileprovider.h b/src/gui/macOS/fileprovider.h
@@ -21,6 +21,8 @@
 
 namespace OCC {
 
+class Application;
+
 namespace Mac {
 
 // NOTE: For the file provider extension to work, the app bundle will
@@ -32,14 +34,18 @@ class FileProvider : public QObject
 
 public:
     static FileProvider *instance();
-    ~FileProvider() = default;
+    ~FileProvider() override;
 
     static bool fileProviderAvailable();
 
 private:
-    explicit FileProvider(QObject * const parent = nullptr);
     std::unique_ptr<FileProviderDomainManager> _domainManager;
     std::unique_ptr<FileProviderSocketServer> _socketServer;
+
+    static FileProvider *_instance;
+    explicit FileProvider(QObject * const parent = nullptr);
+
+    friend class OCC::Application;
 };
 
 } // namespace Mac

diff --git a/src/gui/macOS/fileprovider_mac.mm b/src/gui/macOS/fileprovider_mac.mm
@@ -24,11 +24,13 @@
 
 namespace Mac {
 
-static FileProvider *_instance = nullptr;
+FileProvider* FileProvider::_instance = nullptr;
 
 FileProvider::FileProvider(QObject * const parent)
     : QObject(parent)
 {
+    Q_ASSERT(!_instance);
+
     if (!fileProviderAvailable()) {
         qCDebug(lcMacFileProvider) << "File provider system is not available on this version of macOS.";
         return;
@@ -61,6 +63,11 @@
     return _instance;
 }
 
+FileProvider::~FileProvider()
+{
+    _instance = nullptr;
+}
+
 bool FileProvider::fileProviderAvailable()
 {
     if (@available(macOS 11.0, *)) {