UI: Improves texts displayed to the user when picking the wrong location for syncing #7596
+58
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rello
reviewed
Dec 3, 2024
camilasan
force-pushed
the
bugfix/network
branch
from
24870d0 to
1db1c48
Compare
|
AppImage file: nextcloud-PR-7596-f57f894fee3403f640a494ea57c6ddb3cd339d8c-x86_64.AppImage |
camilasan
changed the title
camilasan
changed the title
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
…ng synced. Signed-off-by: Camila Ayres <[email protected]>
camilasan
force-pushed
the
bugfix/network
branch
from
f57f894 to
9c02bf3
Compare
8 tasks
Signed-off-by: Camila Ayres <[email protected]>
|
Artifact containing the AppImage: nextcloud-appimage-pr-7596.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
nilsding
requested changes
Jan 27, 2025
| return tr("The Virtual filesystem feature requires a NTFS file system, %1 is using %2").arg(path, fs); | ||
| if (const auto fileSystemForPath = FileSystem::fileSystemForPath(info.absoluteFilePath()); | ||
| fileSystemForPath != QLatin1String("NTFS")) { | ||
| return tr("Please choose a different location. %1 isn't a NTFS files system. It doesn't support virtual files.").arg(path); |
There was a problem hiding this comment.
small typo:
Suggested change
| return tr("Please choose a different location. %1 isn't a NTFS files system. It doesn't support virtual files.").arg(path); | |
| return tr("Please choose a different location. %1 isn't a NTFS file system. It doesn't support virtual files.").arg(path); |
| @@ -63,9 +63,9 @@ QString FormatWarningsWizardPage::formatWarnings(const QStringList &warnings) co | |||
| { | |||
| QString ret; | |||
| if (warnings.count() == 1) { | |||
| ret = tr("<b>Warning:</b> %1").arg(warnings.first()); | |||
| ret = tr("%1").arg(warnings.first()); | |||
There was a problem hiding this comment.
there is no need for this tr("%1"), just warnings.first() will do fine here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves texts displayed to the user when picking the wrong location for syncing: