[stable29] fix: Pin pdfjs-dist to exact 4.0.189 #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PDF viewer explicitly sets "isEvalSupported" to "false", so it is not affected by the security issue reported for versions <= 4.1.392, which assume the default value of "true". pdfjs-dist is the main dependency of the PDF viewer, and any version update requires additional work in the PDF viewer, it is not just increasing the version and that is it. Due to all of the above, the pdfjs-dist version is pinned for now to exact 4.0.189 to avoid dealing again and again with incorrect updates after running "npm audit fix". Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
dependencies
szaimen
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #1163