Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only attempt to use a secure view if hide download is actually set #292

Merged
merged 1 commit into from
Jan 24, 2021

Conversation

juliusknorr
Copy link
Member

Only assume using a secure viewer (Collabora) if hideDownload is actually enabled

Fixes nextcloud/richdocuments#1320

@rullzer rullzer merged commit 6c4a18e into master Jan 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the bugfix/no-secure-view-by-default branch January 24, 2021 08:02
@rullzer
Copy link
Member

rullzer commented Jan 24, 2021

@juliushaertl backports?

@fabianbur
Copy link

The current version of PDF viewer is 2.0.1 and it hasn't been updated in a long time. At what time will this fix be included in a version that is updated in the normal way?

Is there a beta version that can be installed until an update is released?

@rullzer rullzer mentioned this pull request Jan 27, 2021
19 tasks
@juliusknorr
Copy link
Member Author

/backport to stable20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdf fiiles it looks like a downloadable file with a preview
3 participants