-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix focus lost to body when closing firstrunwizard #1073
Conversation
Pytal
commented
Feb 1, 2024
- Fix [BITV] Focus is lost to body when closing firstrunwizard #1072
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
/backport 99d0777 to stable28 |
I tested this and it doesnt seem to work since the menu seems to close when you open the firstrunwizard: recordedVideo2024-02-02-124820.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my eyes it works well, thank you!
But actually this app is disabled and it was decided to leave firstrunwizard
disabled
Maybe not intuitive but the menu is supposed to close and the focus returns to the avatar button
Right! |
Yes, definitely not intuitive. Shouldnt the menu stay open? |
Nope, was discussed already that only when the menu is open it retains focus and is otherwise closed for a11y |
All right |