Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Google OAuth support #6830

Closed
wants to merge 6 commits into from
Closed

Add Google OAuth support #6830

wants to merge 6 commits into from

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jul 4, 2022 •
edited
Loading

Fixes #6454

Todo

  • Show Sign in with Google
  • Properly restructure setup procedure to work well with fully automatic, manual and mixed setups Split auto config and account creation #6831
  • Save Google's refresh and access token after successful redirection back
  • If necessary update access token before an IMAP client is built
  • Make sure the browser doesn't block the Google popup
  • Check/fix account update procedure
  • Handle closed popup
  • Handle failed/cancelled user consent
  • Admin settings page UI
  • Any other edge cases
  • Test migration from app password to oauth
  • Test migration from broken account (login password) to oauth

@ChristophWurst
Add Google OAuth support
7d14d4a 
Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst self-assigned this Jul 4, 2022
This was referenced Jul 4, 2022
Closed
Merged
@ChristophWurst
Copy link
Member Author

Note to self: merge+making it work is in commit e93971446091f049bd373d7180073505cecfa115

@ChristophWurst
Copy link
Member Author

mail_auto_setup-2022-07-08_15.01.03.webm

@ChristophWurst ChristophWurst mentioned this pull request Oct 13, 2022
Merged
@ChristophWurst
Copy link
Member Author

This branch is becoming a bit hard to manage. I'm extracting the generic parts into separate PRs:

@ChristophWurst ChristophWurst mentioned this pull request Oct 14, 2022
Merged
9 tasks
@ChristophWurst
Copy link
Member Author

Superseded by #7430

@ChristophWurst ChristophWurst deleted the feature/google-oauth branch October 31, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb Awaiting requested review from kesselb kesselb will be requested when the pull request is marked ready for review kesselb is a code owner

@GretaD GretaD Awaiting requested review from GretaD GretaD will be requested when the pull request is marked ready for review GretaD is a code owner

Assignees

@ChristophWurst ChristophWurst

Labels
2. developing enhancement feature:integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GMail compatibility without app passwords
1 participant
@ChristophWurst